Microsoft/monaco-editor

TS regex missed by Monarch grammar

Open

#2,512 opened on Jun 2, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,283 forks)batch import
buggrammarshelp wantedtypescript

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

Extracted from https://github.com/microsoft/TypeScript-Website/issues/1870

const x = true ? /^([^"]*)"/ : /^([^']*)'/

/^([^"]*)"/ is not identified as a regex by the TS Monarch grammar, which breaks bracket matching:

image

Contributor guide

Research direction
Study the TypeScript Monarch grammar file and identify how regex tokens are recognized; then adjust the grammar to recognize regex patterns after `/: /^([^\"]*)\"/` in ternary expressions.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptMonarch grammar
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40