Microsoft/monaco-editor

[Monarch Julia grammar] interpolation breaks inside multiline strings

Open

#2,357 opened on Feb 17, 2021

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
buggrammarshelp wanted

Description

monaco-editor version: 0.22.3 Browser: Google Chrome 88.0.4324.182 (Official Build) (64-bit) (cohort: 88_Win_182) OS: Windows 10

Hi!

Using the built-in julia mode, string interpolation inside a multiline string seems to break the syntax highlighting whenever any right parenthesis ) is encountered, not just the final one that closes the interpolation. Example:

Multiline_interpolation_breaks_in_monaco

I had a little go at it but I have to learn more about Monarch before I can be of any use here. Here's a codesandbox with some more test cases, and an editable copy of the current julia mode included with monaco-editor for easy experimenting.

Contributor guide

Tech stack
typescriptjavascript
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of Monarch grammarsknowledge of Julia string interpolation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the current Julia Monarch grammar file (likely at src/basic languages/julia/julia.ts). Use the provided CodeSandbox to reproduce the bug where interpolation breaks on encountering ')' inside multiline strings. The grammar's string interpolation rules need to be updated to handle multiline context. Study how other language grammars in Monaco handle similar cases for reference.