Microsoft/monaco-editor

Keyword "field" is highlighted in Kotlin package names

Open

#2,351 opened on Feb 14, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
buggrammarshelp wanted

Description

Create Kotlin file foo.kt with content:

package com.boo.field
import com.foo.field.bar

View it it Azure DevOps web commit history, web editor or PR view (anywhere where code is displayed), notice "field" is highlighted blue. This is because "field" is keyword in Kotlin, but keywords should not apply for package names.

Note: this issue was redirected to monaco by Azure Dev Ops support: "This issue seems to be caused by Monaco-languages and not Visual Studio. Please file a ticket with that product at https://github.com/microsoft/monaco-languages" https://developercommunity2.visualstudio.com/t/DevOps-code-viewer-highlights-field-in/1299514?entry=myfeedback&space=21

Contributor guide

Tech stack
javascripttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Monaco language definitionsBasic understanding of Kotlin syntax
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is in the Kotlin language grammar definition in the monaco languages repository. Look for the Kotlin tokenizer/grammar file (likely written in TypeScript). The keyword 'field' should be removed from the keyword list or the matching rules should ensure it is only highlighted as a keyword in certain contexts (not in package names). Check the monaco languages Kotlin grammar and modify the tokenization rules to exclude 'field' from keyword highlighting when it appears in package declarations.
Keyword "field" is highlighted in Kotlin package names · Microsoft/monaco-editor#2351 | Good First Issue