Microsoft/monaco-editor

Keyword "field" is highlighted in Kotlin package names

Open

#2,351 opened on Feb 14, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,283 forks)batch import
buggrammarshelp wanted

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

Create Kotlin file foo.kt with content:

package com.boo.field
import com.foo.field.bar

View it it Azure DevOps web commit history, web editor or PR view (anywhere where code is displayed), notice "field" is highlighted blue. This is because "field" is keyword in Kotlin, but keywords should not apply for package names.

Note: this issue was redirected to monaco by Azure Dev Ops support: "This issue seems to be caused by Monaco-languages and not Visual Studio. Please file a ticket with that product at https://github.com/microsoft/monaco-languages" https://developercommunity2.visualstudio.com/t/DevOps-code-viewer-highlights-field-in/1299514?entry=myfeedback&space=21

Contributor guide

Research direction
Locate the Kotlin language definition in monaco languages. Find where 'field' is listed as a keyword. Modify the tokenizer to exclude keywords in package declarations (e.g., after 'package' keyword). Test by creating a Kotlin file with 'package com.boo.field' and verify no highlighting on 'field'.
Tech stack
javascripttypescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScriptTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65