Microsoft/monaco-editor

Native browser undo/redo commands take incorrect effect to the editor content

Open

#2,346 opened on Feb 10, 2021

View on GitHub
 (0 comments) (11 reactions) (0 assignees)JavaScript (1,283 forks)batch import
bugeditor-inputhelp wanted

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

monaco-editor version: 0.22.3 Browser: Firefox 85 OS: Windows 10 Playground code that reproduces the issue:

function x() {
	console.log("Hello world!");
}

I've reproduced it by the following steps:

  1. Start Monaco playground.
  2. Type some text.
  3. Click the Undo item in the browser menu bar.
  4. Nothing happens.
  5. Click the Redo item in the browser menu bar.
  6. The entered text will be duplicated.
  7. Also, doesn't work with document.execCommand('undo') in Chrome.

monaco-editor-undo-redo

Contributor guide

Research direction
Investigate how Monaco Editor intercepts native browser undo/redo commands (Ctrl+Z/Ctrl+Y) and trace the event handling path to identify why the commands are not working correctly.
Tech stack
javascripttypescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
basic understanding of browser undo/redoknowledge of Monaco Editor internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75