Microsoft/monaco-editor

Chinese IME does not work correctly with CompletionItemProvider

Open

#2,199 opened on Oct 20, 2020

View on GitHub
 (5 comments) (2 reactions) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
bugeditor-input-IMEhelp wantedsuggest

Description

If set suggestion label as a chinese text, the auto complete item will never show when input with chinese IME like sougou.

And I found that the suggestion check is triggered in 'compositionupdate' event instead of 'compositionend,' then the selection check is failed, the preSelection(typed alpha text) is after currentSelection(chinese text):

//  in suggestModel.js : _onCursorChange

(!prevSelection.containsRange(this._currentSelection) && !prevSelection.getEndPosition().isBeforeOrEqual(this._currentSelection.getPosition()))

In vscode there is same problem. the snippets with chinese label doesn't not work.

Contributor guide

Tech stack
javascripttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of IME composition eventsknowledge of JavaScript event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine suggestModel.js, specifically the onCursorChange method where compositionupdate event handling is used. Compare with compositionend event. Check if the condition on line mentioned (preSelection after currentSelection) can be adjusted. Also review Monaco's handling of IME input and any existing vscode workarounds.