Microsoft/monaco-editor

Improve Go syntax highlighting

Open

#1,770 opened on Jan 17, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
feature-requestgrammarshelp wantedopen for PR

Description

monaco-editor version: 0.19.3 Browser: Chrome 79 maybe OS: macOS Mojave Playground code that reproduces the issue:

monaco.editor.create(document.getElementById("container"), {
	value: 'fmt.Println("666")',
	language: "go"
});

How Monaco/Monarch highlights things:

image

How VSCode highlights things:

Also in VSCode (latest, not Insiders) that line of code is highlighted differently once rendered from Markdown, I think it's ok to expect some differences since my editor has a dark background and the rendered Markdown has a light background, but here a method's name is no longer of a different color as far as I can see, and that seems a bit too much of a difference:

Contributor guide

Tech stack
gojavascripttypescript
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Go syntaxUnderstanding of Monarch tokenizerBasic JavaScript/TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the Go language definition file (likely src/basic languages/go/go.ts) to compare the tokenizer rules with VSCode's Go highlighting. Identify the rules that produce incorrect colors for string literals and method names. Adjust the Monarch tokenizer rules to match VSCode's output, ensuring string literals are colored correctly and method names are distinguished from regular function calls. Test the changes locally using the Monaco editor development environment.