Microsoft/monaco-editor

Make monaco-editor-samples have independent folders

Open

#1761 opened on Jan 10, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
documentationfeature-requesthelp wanted

Description

Please include /node_modules/ in .gitignore for the samples that have a .gitignore file, as appropriate.

After I copy the sample into my own repository and run yarn install, if I didn't check before running git add ., I would have added everything under node_modules/.

Contributor guide

Tech stack
javascriptnodejs
Domain
developer experiencetooling
Issue type
chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of Node.js projects
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Locate sample folders in the repository (e.g., under 'samples/'). For each sample folder that contains a .gitignore file, add a line '/node modules/' to ignore the node modules directory. If a sample folder does not have a .gitignore, consider whether one should be created. This change ensures that users copying the samples do not accidentally commit node modules. The issue is straightforward and requires no additional dependencies.