Microsoft/monaco-editor

Make monaco-editor-samples have independent folders

Open

#1,761 opened on Jan 10, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,283 forks)batch import
documentationfeature-requesthelp wanted

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

Please include /node_modules/ in .gitignore for the samples that have a .gitignore file, as appropriate.

After I copy the sample into my own repository and run yarn install, if I didn't check before running git add ., I would have added everything under node_modules/.

Contributor guide

Research direction
Check which samples have .gitignore files and ensure /node modules/ is included.
Tech stack
javascript
Domain
tooling
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90