Microsoft/monaco-editor

sample electron-amd/electron-index.html have problem with path including special characters, such as #

Open

#1718 opened on May 29, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
documentationfeature-requesthelp wantedopen for PR

Description

electron-amd/electron-index.html declares a function named uriFromPath to handle file paths, but it seems that if a file path has # or other special characters in it, the amdRequire won't work.

https://github.com/Microsoft/monaco-editor-samples/blob/779a88524d1755ad087420ce459b37199bf4df0e/electron-amd/electron-index.html#L28-L34

Contributor guide

Tech stack
javascripthtml
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue is in the `uriFromPath` function in `electron amd/electron index.html`. The function does not encode special characters like `#` in file paths, causing `amdRequire` to fail. The fix likely involves using `encodeURIComponent` or a similar method to escape special characters. See the linked line: https://github.com/Microsoft/monaco editor samples/blob/779a88524d1755ad087420ce459b37199bf4df0e/electron amd/electron index.html#L28 L34.