Microsoft/monaco-editor

PHP: support for code snippets without the starting `<?php` token

Open

#1,658 opened on Nov 5, 2019

View on GitHub
 (4 comments) (3 reactions) (0 assignees)JavaScript (1,283 forks)batch import
feature-requestgrammarshelp wanted

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

monaco-editor version: 0.18.1

Steps or JS usage snippet reproducing the issue:

The following snippet doesn't get highlighted properly because the starting <?php token is missing, I think it should get highlighted better, like GitHub is doing, even though the current behavior is probably overall more correct, but kind of too strict.

public function index() {
    $projects = Project::all();

    return view('projects.index', compact('projects'));
}

Contributor guide

Research direction
Investigate monaco editor's PHP tokenizer and modify the grammar to highlight PHP code even without the opening <?php tag, while ensuring backward compatibility.
Tech stack
typescriptjavascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60