Microsoft/monaco-editor

PHP: does not work highlight for interpolated variable;

Open

#1,431 opened on May 1, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (1,283 forks)batch import
feature-requestgrammarshelp wantedopen for PR

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

Browser: Chrome OS: win7

image same code on pastebin https://pastebin.com/hWfu4g52

Contributor guide

Research direction
Look for the PHP grammar definition in the monaco editor source code, specifically the part that handles string interpolation in double quoted strings. Check the TextMate grammar or Monarch grammar for PHP. Identify the rule that matches interpolated variables and trace why it might fail.
Tech stack
javascriptphp
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65