Microsoft/monaco-editor

PHP: does not work highlight for interpolated variable;

Open

#1431 opened on May 1, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
feature-requestgrammarshelp wantedopen for PR

Description

Browser: Chrome OS: win7

image same code on pastebin https://pastebin.com/hWfu4g52

Contributor guide

Tech stack
javascripttypescript
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic PHP syntaxUnderstanding of TextMate grammars
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Examine the PHP language definition file in monaco editor (likely src/basic languages/php.ts) to identify the tokenization rule for string interpolation. Reproduce the issue with a PHP snippet containing interpolated variables inside double quoted strings. Review any existing comments for additional context. The fix would involve adjusting the regex pattern to correctly highlight variables like $this within strings.