Microsoft/calculator

Enable code analysis on all projects and resolve warnings

Open

#693 opened on Oct 1, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (16,196 stars) (2,422 forks)batch import
Pri: 2approvedbuildcodebase qualityhelp wanted

Description

Visual Studio's code analysis tools can help find issues in our C++ code. Eventually, it would be great to have these tools running in all of our builds and to fix all the warnings they generate.

See #689 for an example of how to enable the tools during the build. We'll enable code analysis only in the "Release" configuration to avoid slowing down Debug builds.

To see which warnings still need to be fixed, check a recent build from the master branch.

It would be best to submit fixes for unrelated warnings as separate PRs. I'll close out this issue when 1) all C++ projects are building with code analysis rules on and 2) all the warnings generated by those tools are fixed or silenced.

Contributor guide

Tech stack
cpp
Domain
toolingbuild systemci cd
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ basicsVisual Studio build configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review issue #689 for an example of enabling code analysis during build. Examine the Release configuration in project files. Check the Azure DevOps build link to see current warnings. Plan to fix warnings in separate PRs as suggested.