Microsoft/calculator

Update calc engine to remove existence of negative 0

Open

#67 opened on Feb 27, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (2,422 forks)batch import
Pri: 2approvedcodebase qualityhelp wanted

Repository metrics

Stars
 (16,196 stars)
PR merge metrics
 (Avg merge 15h 43m) (7 merged PRs in 30d)

Description

The current calc engine has many cases that result in a calculation of negative 0. While there are a couple spots where this is checked and resolved (2, to be exact), this should be improved to prevent cases like "not(1-1) = -1".

Contributor guide

Research direction
Investigate the calculation engine code to identify where negative zero is produced and ensure it is consistently resolved. Look for places where arithmetic operations can produce 0.0 and add checks to convert to positive zero.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75