Microsoft/calculator

[RS5+] Update NavigationView to use DataTemplates and a template selector to generate menu in XAML rather than in code

Open

#63 opened on Feb 27, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (2,422 forks)batch import
Pri: 2approvedcodebase qualityhelp wanted

Repository metrics

Stars
 (16,196 stars)
PR merge metrics
 (Avg merge 15h 43m) (7 merged PRs in 30d)

Description

Once our min version is RS5, we can update our app to use DataTemplates in the NavigationView. Downlevel, this is bugged and a DataTemplate with a NavigationViewItem/NavigationViewItemHeader as the top-level element will result in a double-nested item container.

Contributor guide

Research direction
Review the current NavigationView code and implement DataTemplates and template selector in XAML.
Tech stack
cpp
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70