Microsoft/calculator

Length conversion should use Feet + Inches instead of Feet with decimal point

Open

#57 opened on Feb 27, 2019

View on GitHub
 (5 comments) (11 reactions) (0 assignees)C++ (2,422 forks)batch import
EnhancementPri: 2help wantedneeds spec

Repository metrics

Stars
 (16,196 stars)
PR merge metrics
 (Avg merge 15h 43m) (7 merged PRs in 30d)

Description

Problem Statement Today, length converter shows decimal values for feet, while in practice, feet + inches are oftentimes used.

Evidence or User Insights Observation of current behavior and customary use in U.S. and U.K. Details on foot (unit).

Proposal When converting to feet, in addition to showing the decimal conversion, also include "feet + inches", which is more commonly used when working in this unit. For example, when converting 230cm, Calculator shows 7.545932 feet. It would be more useful if it would also show 7' 6.55" (feet with inches).

Possibly dependent on #379.

Goals

  • Additionally show the "feet and inches" conversion when working with feet in length converter.

Non-Goals

  • Remove decimal representation of values in feet

Low-Fidelity Concept image

Requested Assignment I'm just suggesting this idea. I don't want to implement it.

Contributor guide

Research direction
Locate the length conversion logic in Calculator/UnitConverter/UnitConverter.cpp. Identify where feet conversion is performed and add an additional output for feet+inches format (e.g., '7\' 6.55"'). Ensure to handle rounding and display in the UI.
Tech stack
None
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70