Microsoft/calculator

Calculator should not use FrameworkElement.Tag as it can be easily overwritten by internal control logic.

Open

#56 opened on Feb 27, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (2,422 forks)batch import
Pri: 3approvedcodebase qualityhelp wanted

Repository metrics

Stars
 (16,196 stars)
PR merge metrics
 (Avg merge 15h 43m) (7 merged PRs in 30d)

Description

The use of the Tag property is bad practice and we should clean up the buttons that still use it. Tag is currently used for:

  • Hamburger Button (fixed by move to NavigationView)
  • About Button (fixed by move to NavigationView)
  • OpenParenthesis buttons
  • Programmer mode radix buttons (BIN/OCT/DEC/HEX)

Contributor guide

Research direction
Search for all usages of the Tag property in button related XAML and code behind files, then replace each with a more robust approach like a custom dependency property or data binding.
Tech stack
cpp
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++XAML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70