Microsoft/calculator

"Previous", "Next" and "Year" buttons are not adopting High contrast black and white themes properly

Open

#388 opened on Mar 26, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (16,196 stars) (2,422 forks)batch import
Area: AccessibilityBugPri: 2help wantedtriage approved

Description

Pre-Requisite Turn on High contrast using Settings -> Ease of Access -> High contrast -> High contrast black and white.

Repro Steps

  • Launch Calculator app.
  • Navigate to Menu and Select Date calculation.
  • Select Difference between dates from the combo box.
  • Navigate to From field and press enter.
  • Date calendar picker will open
  • Navigate to Previous, Next and Year buttons.
  • Observe the issue.

image

Actual Result Previous, Next and Year buttons are of blue color in High contrast white theme and of Yellow color in high contrast black theme.

Expected Result We should be consistent with the default contorl. Previous, Next and Year buttons should be of black color in High contrast white theme and of white color in high contrast black theme. Buttons should have an outline.

Test Environment OS Version: Windows 10 Build 18351.1 App Name: Calculator App Version: 10.1902.16.0

Contributor guide

Tech stack
cpp
Domain
desktopaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Windows High Contrast themingXAML styling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Investigate the XAML styles for the DatePicker's navigation buttons (e.g., in CalendarView style). Locate where foreground and background colors are defined for high contrast themes. The issue reports that buttons show blue or yellow instead of system colors. Likely the styles use hardcoded colors instead of theme resources like ButtonForeground. Check resource dictionaries for high contrast overrides and modify the styles to use system brushes. Review the Calculator app's XAML files for any existing high contrast adaptations.