Microsoft/calculator

Pasting long decimal number results in Invalid input

Open

#162 opened on Mar 7, 2019

View on GitHub
 (14 comments) (2 reactions) (1 assignee)C++ (16,196 stars) (2,422 forks)batch import
Area: User ExperienceBugPri: 3help wantedtriage approved

Description

Describe the bug When pasting a decimal number with more than 16 decimal digits, the calculator outputs Invalid input.

Steps To Reproduce Paste 0.00012345678987654 into the calculator.

Expected behavior The input to be accepted. If it is too long, trim it, like the Windows 7 calculator does.

Screenshots image

Device and Application Information (please complete the following information):

  • OS Build: 18334.1.amd64fre.19h1_release.190205-1505
  • Architecture: x64
  • Application Version: 10.1812.10048.0

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ basicscalculator input parsingstring manipulation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the calculator's input parsing code, likely in a file handling paste events. Identify where the decimal string length is validated and causes 'Invalid input'. Consider trimming excess digits before conversion, similar to the Windows 7 calculator. Files to look at include those related to number conversion in the source repository.