Microsoft/calculator

Typing the most negative number by numpad not possible

Open

#1541 opened on May 12, 2021

View on GitHub
 (7 comments) (3 reactions) (0 assignees)C++ (16,196 stars) (2,422 forks)batch import
Area: User ExperienceBugPri: 2help wantedtriage approved

Description

Hello, steps to reproduce:

  • Switch to programmers mode (Alt+3)
  • Switch number size to BYTE
  • Now it is not possible to just simply enter a value -128 by numeric keyboard.

I am programmer and I found out reasons why it is not possible. You binded a minus input with an operation minus and then expecting a positive value which +128 is not valid. But your focus should be to user experience and I as a user started typing negative value -128. And it really should be possible to just enter a simple number like -128 which is in hexa 0x80 fully valid number.

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ basicsWindows event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue involves the input handling for the numpad minus key in calculator's programmer mode. Look at the NumPad key event handlers in CalcInput.cpp or similar files. The current implementation treats the minus key as an operation, but it should treat it as a sign when entering a number. A solution would be to check if the current input state allows a sign and insert the negative sign accordingly. Review the comments in the issue for additional context on the expected behavior.