Microsoft/TypeScript

DefinitionResponse selects full type range

Open

#8,808 opened on May 25, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (48,455 stars) (6,726 forks)batch import
Domain: APIHelp WantedSuggestion

Description

When sending a definition request to the tsserver, the response contains a range selection of the whole type. For UX proposes it would be better to either select only the identifying portion, like a type name, or additional include such an identifying range.

See https://github.com/Microsoft/vscode/issues/6772 for some background.

Contributor guide

Tech stack
typescript
Domain
backenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with TypeScript compiler internalsunderstanding of tsserver protocol
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the tsserver codebase, specifically the response generation for definition requests. Look at files like src/services/classifySymbol.ts or relevant handlers. The goal is to identify and extract a more precise range (e.g., just the type name) from the full type range currently returned. Review linked issue in vscode for additional context. Contribute a PR that modifies the response to include an identifyingRange alongside the existing full range.