Microsoft/TypeScript

Do not rename imports from ambient modules

Open

#8,227 opened on Apr 20, 2016

View on GitHub
 (6 comments) (3 reactions) (0 assignees)TypeScript (48,455 stars) (6,726 forks)batch import
Effort: ModerateHelp WantedSuggestion

Description

Issue explained by @bbgone in https://github.com/Microsoft/TypeScript/issues/8118#issuecomment-212218038

Renaming an import alias for a module coming from a .d.ts file, renames all instances. this is obviously wrong.

Options, 1. error (obviously not helpful), 2. only rename local symbol (better, but leaves the code in an invalid state), 3. rename local import and add as oldname clause to the import declaration as needed (looks like the best solution).

This is similar to the issue related to https://github.com/Microsoft/TypeScript/issues/7458, except that this issue adds renaming the import alias.

Contributor guide

Tech stack
typescript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript module systemCompiler rename logicAmbient module declarations
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the TypeScript compiler's rename functionality, particularly how imports from .d.ts files are handled. The issue suggests that renaming an import alias from an ambient module incorrectly renames all instances. Proposed solution is to rename only the local symbol and add an 'as oldname' clause. Examine the relevant code in the compiler's rename module to identify where the global rename occurs and modify it to handle ambient modules differently, ensuring the fix aligns with existing behavior for non ambient modules.
Do not rename imports from ambient modules · Microsoft/TypeScript#8227 | Good First Issue