Microsoft/TypeScript

Covariant generic parameters fail unification

Open

#61,503 opened on Mar 28, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: check: Type InferenceHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

🔎 Search Terms

"contravariant", "unification"

🕗 Version & Regression Information

  • This changed between versions 3.3.3 and 3.5.1

⏯ Playground Link

https://www.typescriptlang.org/play/?jsx=0#code/MYewdgzgLgBKZQE4EMBuzEEtkJgXhgAoBKfAPhgG8AoGOcaegWwCNMwBTfGAHgGEoADzKEA+gEYAXEWCSBg0ngpgArgBs1AGhiiATNMKz5i5erXEDJmPPJErKsABMOAM3YdHMZBC9gAngDc1LT0kLBqHBAQovDQWJyeBPwwHIJQHE4+lBFgAOZQABaSqqwciAC+IrLWFjCqGrb1akF0sbBMIIgcMQxI7om8fClpGY5ZOflFJSxl2sAFGHwgzgCCUGLFKqWIFtNllYbSfLVNjWYtoYzp0OLcoKzuhBFRPWHxHtodXa9x-cQXbRg1ygujuIAenEIX26bXejm0z2isL+AN6MEQ3GB4hIQXKwUBoHQWBwsAIJFsNFaaPubE43H4QhEEkstnk2j0LKU1iEtRsXIczjcCS8PhwgWCVLCMERPz6wqSQ1S6UyVAmhU22wOvNsAtc-RFvnFksY0NlcPpipGKuyGUmGpmiDmC0QS1W61E9rKuy2Dq1Rx1Tj1wu8htRUqxYIhHCekSRvThn06MPjKJCgOBoIINMepuRCQRsbNqfKQA

💻 Code

const contravariant = () => {
  const combine = <Ctx>(_1: (c:Ctx) => null, _2: (c:Ctx) => null): () => Ctx => () => undefined as any;

  const less_constrined = <C extends {length:number}>(c: C): null => null;
  const more_constrined = <C extends {length:number, charCodeAt(_:number):number}>(c: C): null => null;
  const test1 = combine(less_constrined, more_constrined);
  const test2 = combine(more_constrined, less_constrined);
}

const covariant = () => {
  const combine = <Ctx>(_1: () => Ctx, _2: () => Ctx): Ctx => undefined as any;

  const less_constrined = <C extends {length:number}>(): C => undefined as any;
  const more_constrined = <C extends {length:number, charCodeAt(_:number):number}>(): C => undefined as any;
  const test1 = combine(less_constrined, more_constrined);
  const test2 = combine(more_constrined, less_constrined);
}

🙁 Actual behavior

In the contravariant example the type is inferred from the first argument, so test1 fails to typecheck, despite both test1 and test2 sharing the same argument types, just reversed. This is also different from the covariant case where types are properly unified in both test1 and test2

🙂 Expected behavior

The behaviour for the covariant and contravariant case should match, so test1 should be inferred as <C extends { length: number; charCodeAt(_: number): number; }>() => C

Additional information about the issue

No response

Contributor guide