Microsoft/TypeScript

MIDIMessageEvent data is incorrectly typed

Open

#60,546 opened on Nov 20, 2024

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: lib.d.tsHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

🔎 Search Terms

In https://github.com/microsoft/TypeScript/pull/57027 MIDIMessageEvent.data was changed from Uint8Array to Uint8Array | null (see https://github.com/microsoft/TypeScript/pull/57027/files#diff-dc0eab937d15e62545da3ed7b4f40ad6b24f15dd88fbc6ceda2bfb4ed8356eb0L14670).

According to https://developer.mozilla.org/en-US/docs/Web/API/MIDIMessageEvent/data data the value will always be an Uint8Array.

🕗 Version & Regression Information

This changed in #57027

⏯ Playground Link

No response

💻 Code

🙁 Actual behavior

'event.data' is possibly 'null'.ts(18047)

🙂 Expected behavior

No warning about data property possibly being null.

Additional information about the issue

No response

Contributor guide

Research direction
Review the WebIDL spec for MIDIMessageEvent.data and check PR #57027 to confirm that null is invalid; then update the type definition in lib.dom.d.ts accordingly.
Tech stack
typescript
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80