Microsoft/TypeScript

[5.5 regression] "Maximum call stack size exceeded" when serializing nested self-referencing class expressions

Open

#59,600 opened on Aug 12, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: Declaration EmitHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

🔎 Search Terms

dts declaration serializing class expression self-referencing nested

🕗 Version & Regression Information

  • This changed between versions 5.4.x and 5.5.x

⏯ Playground Link

https://www.typescriptlang.org/play/?ts=5.6.0-dev.20240812#code/MYewdgzgLgBAgjAvDYAbAhhC8A8AVAPhgG8AoGFACwEtUATAQgC4YBJSKdMYAUzwE8ADjxxQhPEADN4AOgBC+AgQDc5GNHRRqwGHKQoMWXYpJqKg9ACceYKMxh5VFAL6rXpIA

💻 Code

const A = class A<T> {
  child!: InstanceType<typeof A.B<T>>;
  static B = class B<T> {
    parent!: T;
  };
};

🙁 Actual behavior

it crashes

🙂 Expected behavior

it shouldn't crash 😉

Additional information about the issue

No response

Contributor guide

Research direction
Inspect the serialization logic for class expressions in the TypeScript compiler to find the infinite recursion. Trace how self referencing nested classes lead to stack overflow.
Tech stack
typescript
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30