Microsoft/TypeScript

Debug Failure. Did not expect ObjectLiteralExpression to have an Identifier in its trivia

Open

#58,027 opened on Apr 1, 2024

View on GitHub
 (7 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: CrashesHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

🔎 Search Terms

identifier unicode es5 es2015 trivia object literal expression failure

🕗 Version & Regression Information

  • This is a crash
  • This changed between versions ______ and _______
  • This changed in commit or PR _______
  • This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
  • I was unable to test this on prior versions because _______

⏯ Playground Link

https://www.typescriptlang.org/play?target=1&ts=5.5.0-dev.20240401#code/PTAEAEBcEMCcHMCmkBcpEGcCsAoAbnKAOKgC8oA3qIKwbgILtoBEAZAIIBmsA3A6AL6c4gA

💻 Code

// @target: es5
var G = { 𝔄: "𝔄" };

🙁 Actual behavior

TS server crashes when hovering over this property

🙂 Expected behavior

it shouldn't crash

Additional information about the issue

repro based on https://github.com/microsoft/TypeScript/issues/58018#issuecomment-2028929069

Contributor guide

Research direction
Look at how the parser handles trivia (comments/whitespace) for identifiers in object literals, specifically for Unicode characters like Gothic letters. Trace where the debug assertion fails during hover information retrieval.
Tech stack
typescript
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
TypeScriptAST
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25