Microsoft/TypeScript

Mirror cursor for JSX stops working in some case

Open

#56,669 opened on Sep 20, 2023

View on GitHub
 (3 comments) (1 reaction) (0 assignees)TypeScript (48,455 stars) (6,726 forks)batch import
BugDomain: JSX/TSXHelp Wanted

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.82.2
  • OS Version: windows 11

Steps to Reproduce:

  1. Typing const a = () => <A.B foo="bar"></A.B>
  2. Remove B character (it will be removed from both side)
  3. Write any characters (It stop writing on both side)

https://github.com/microsoft/vscode/assets/27840664/1fa79f18-23e2-405c-afa5-cb6bd8663830

Contributor guide

Tech stack
typescriptreact
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript language serviceJSX parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the TypeScript language service's handling of JSX paired tags. The bug occurs when deleting the closing tag's identifier and then typing. Look at the auto insertion or mirror cursor logic in the VS Code TypeScript extension, likely in src/services/jsx.ts or similar files. Check for recent changes in the language service that might have introduced this regression.