Microsoft/TypeScript

[Rename symbol command] Remove unnecessary named import

Open

#56,497 opened on Nov 21, 2023

View on GitHub
 (2 comments) (1 reaction) (0 assignees)TypeScript (6,726 forks)batch import
Effort: CasualExperience EnhancementHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

  • VS Code Version: 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e)
  • OS Version: macOS Sonoma 14.1.1

Steps to Reproduce:

  1. Create 2 JS files:
// utils.js
export const foo = () => console.log('Hello world!');

// index.js
import { foo as bar } from "./utils.js";

bar();
  1. Put your cursor in the word "foo" in utils.js and use the "Rename Symbol" command (F2 by default) to rename the function to bar.
  2. Observe the import in index.js has changed to import { bar as bar } from "./utils.js". Since the names import is no longer necessary, the command should instead change the import to import { bar } from "./utils.js".

Contributor guide

Research direction
Investigate the Rename Symbol logic in the TypeScript language service to handle cases where the renamed name matches the import name, removing unnecessary alias.
Tech stack
typescript
Domain
compilersdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70