Microsoft/TypeScript

Unwanted auto-imports in script files

Open

#55,256 opened on Aug 3, 2023

View on GitHub
 (14 comments) (0 reactions) (1 assignee)TypeScript (6,726 forks)batch import
Effort: ModerateExperience EnhancementHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Bug Report

I have a mixture of module and non-module code. The problem occurs when I edit non-module files (tsconfig: "module": "none").

Sometimes when using auto-completion (in VisualStudio 2022) typescript finds a "matching" name from the module world and adds a line like

import { HmiHelper } from './helper/HmiHelper.js';

into the first line of my file. But as the current file was configured as "module": "none" this import pushes typescript into modules mode and the current code is invalid.

🔎 Search Terms

intellisense auto-import modules

🕗 Version & Regression Information

This bug is many years old and persists in Typescript 5.1.

Contributor guide

Research direction
Investigate the auto import feature in the TypeScript language service, focusing on how it handles files with 'module: none'. Look for the code that decides to add import statements during auto completion.
Tech stack
typescript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30