Microsoft/TypeScript

ctrl+click on an existing asset with a querystring

Open

#54,993 opened on Jul 12, 2023

View on GitHub
 (0 comments) (2 reactions) (0 assignees)TypeScript (6,726 forks)batch import
Experience EnhancementHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.80.0
  • OS Version: macOS latest

Steps to Reproduce:

  1. write import foo from './existing-file.js?some-query-string'
  2. ctrl+click on the file path

Expected

VSCode opens the file as if there was no querystring

Actual

Either:

  1. VSCode complains with: cannot find module './existing-file.js?some-query-string' or its corresponding type declarations
  2. if there's a .d.ts with declare module '*?some-query-string' {}, VSCode will navigate to this particular declaration block

Contributor guide

Research direction
Investigate how the TypeScript language service resolves module paths for ctrl+click and how querystrings are stripped or ignored. Look at the module resolution logic in the codebase.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60