Microsoft/TypeScript

`ts.isUrl` and `ts.pathIsAbsolute` return false for data urls

Open

#53,605 opened on Mar 31, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: Module ResolutionHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Bug Report

ts.isUrl and ts.pathIsAbsolute return false for data urls.

This is an issue because when using data urls in TypeScript it will join the current working directory with the data url.

🔎 Search Terms

data url ts.isUrl

🕗 Version & Regression Information

ts.version
'5.1.0-dev.20230330'

⏯ Playground Link

N/A

💻 Code

> ts.version
'5.1.0-dev.20230330'
> ts.isUrl("data:application/typescript,42")
false
> ts.isUrl("https://deno.land/mod.ts")
true
> ts.pathIsAbsolute("data:application/typescript,42")
false
> ts.pathIsAbsolute("https://deno.land/mod.ts")
true

🙁 Actual behavior

Output as shown.

🙂 Expected behavior

Should return true for all of the above

Contributor guide

Research direction
Inspect the implementation of `ts.isUrl` and `ts.pathIsAbsolute` in the TypeScript source code to understand why data URLs are not recognized and then add support for the 'data:' protocol.
Tech stack
typescript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70