Microsoft/TypeScript

Infer from usages should not widen literal types

Open

#52,991 opened on Feb 27, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
Domain: LS: RefactoringsExperience EnhancementHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Bug Report

🔎 Search Terms

string literal to string, infer type from usages, code fix, quickfix

⏯ Playground Link

Playground link with relevant code

💻 Code

let a

a = "foo" as "foo" | "bar"

let b

b = getB()

checkB(b)

function checkB(toCheck: "foo" | "bar") {
}

function getB(): "foo" | "bar" {
    return "foo"
}

🙁 Actual behavior

After running infer from usages quickfix, you get string type in a and b positions

🙂 Expected behavior

Should get inffered type "foo"

I think in case of as and satisfies clauses the type should be just copied literally?

As you can see from example this is common case for string enums, like when some function expects some string enum instead of just string, but this information gets lost

Contributor guide