Microsoft/TypeScript

Add semantic token scope for object literal shorthand properties

Open

#52,658 opened on Feb 2, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
Experience EnhancementHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

TS Template added by @mjbvz

TypeScript Version: 4.9.5

Search Terms

  • Semantic tokens
  • semantic colorization

I want a way to configure vscode to treat literal property value shorthand as parameter or variable, not just a property key.

image Above is what happend in vscode. I configure a purple color for parameters, but vscode treat literal property value shorthand as "property" key, not "parameter" or "variable". That's bad for me to find out how parameters are processed in a function quickly.

However, webstorm is ok in this case. image

My settings is as follows:

  "editor.tokenColorCustomizations": {
    "[Default Dark+]": {
      "keywords": "#499CD5",
      "textMateRules": [
        { 
          "scope": "variable.parameter",
          "settings": {
            "foreground": "#C288BE"
          }
        },
      ],
    }
  },

Contributor guide

Research direction
Examine the semantic token classification code in TypeScript's language service, specifically how object literal shorthand properties are assigned semantic tokens, and modify it to treat them as variables or parameters.
Tech stack
typescript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60