Microsoft/TypeScript

Add semantic token scope for object literal shorthand properties

Open

#52,658 opened on Feb 2, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (48,455 stars) (6,726 forks)batch import
Experience EnhancementHelp WantedSuggestion

Description

TS Template added by @mjbvz

TypeScript Version: 4.9.5

Search Terms

  • Semantic tokens
  • semantic colorization

I want a way to configure vscode to treat literal property value shorthand as parameter or variable, not just a property key.

image Above is what happend in vscode. I configure a purple color for parameters, but vscode treat literal property value shorthand as "property" key, not "parameter" or "variable". That's bad for me to find out how parameters are processed in a function quickly.

However, webstorm is ok in this case. image

My settings is as follows:

  "editor.tokenColorCustomizations": {
    "[Default Dark+]": {
      "keywords": "#499CD5",
      "textMateRules": [
        { 
          "scope": "variable.parameter",
          "settings": {
            "foreground": "#C288BE"
          }
        },
      ],
    }
  },

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of TypeScript's semantic token systemFamiliarity with the TypeScript compiler codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the TypeScript semantic token classification system, specifically how shorthand property assignments are tokenized. Look at file 'src/services/classifier.ts' (or similar) to understand current scope assignment for properties. The issue requests a new scope for shorthand property values. No linked PRs or maintainer comments indicate additional constraints. The solution likely involves modifying the classifier to emit a different scope for shorthand properties.
Add semantic token scope for object literal shorthand properties · Microsoft/TypeScript#52658 | Good First Issue