Microsoft/TypeScript

[type bug] fontfaces property is missing from loadingdone event object

Open

#51,885 opened on Dec 14, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (48,455 stars) (6,726 forks)batch import
BugDomain: lib.d.tsHelp Wanted

Description

Configuration Check

My compilation target is ES2015 and my lib is ES2022 & `DOM.

Missing / Incorrect Definition

Request to replace the event type of onloadingdone handler from Event to FontFaceSetLoadEvent, which has been defined in the same module.

https://github.com/microsoft/TypeScript/blob/eb9252ed9e53cd5f2732f14552a01920c4ec9401/lib/lib.dom.d.ts#L5530

https://github.com/microsoft/TypeScript/blob/eb9252ed9e53cd5f2732f14552a01920c4ec9401/lib/lib.dom.d.ts#L5548-L5550

Sample Code

interface FontFaceSet extends EventTarget {
-    onloadingdone: ((this: FontFaceSet, ev: Event) => any) | null;
+    onloadingdone: ((this: FontFaceSet, ev: FontFaceSetLoadEvent) => any) | null;
}

Documentation Link

https://w3c.github.io/csswg-drafts/css-font-loading/#FontFaceSet-events

Contributor guide

Tech stack
typescript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic TypeScript knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
The issue provides a clear diff and references to the specific lines in lib.dom.d.ts. To implement, change the type of onloadingdone from Event to FontFaceSetLoadEvent in the FontFaceSet interface. Verify that FontFaceSetLoadEvent is already defined in the same file. No additional changes needed. Test by compiling TypeScript.