Microsoft/TypeScript

Suggestion isn't included in quick fixes

Open

#50,641 opened on Sep 5, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
Domain: LS: Quick FixesEffort: ModerateExperience EnhancementHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Bug Report

Maybe this is by design, but I still find it a bit awkward. The issue is that the suggestion that appears when hovering over a TS error in VS Code (I could also reproduce it in VS, so it seems like a tsserver behavior and not an IDE thing) isn't included as a quick fix. See the code below for an example.

🔎 Search Terms

  • default
  • export

💻 Code

Say I have file1.ts with the following contents:

const foo = 0;

export default foo;

And I have the following in file2.ts:

import { foo } from './file1';

Because file1.ts has no named exports, the code in the second file has an error. When I hover over the squiggle, VS Code displays: image Despite the dialog mentioning exactly the fix that I would like to apply, that fix isn't included as a possible refactoring: image

My expectation is that the suggestion mentioned in the hover dialog is included as a quick fix.

Contributor guide

Research direction
Investigate the TypeScript language service code that generates quick fixes for diagnostics. Look for the 'QuickFix' interface and the function that creates quick fixes for import related issues. Compare with the hover suggestion logic to see why the fix is not included.
Tech stack
typescript
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65