Microsoft/TypeScript

`ts.convertToBase64` does not handle emojis

Open

#49,150 opened on May 17, 2022

View on GitHub
 (16 comments) (1 reaction) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: Something ElseHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Bug Report

https://github.com/microsoft/TypeScript/blob/da00ba67ed1182ad334f7c713b8254fba174aeba/src/compiler/utilities.ts#L5244

> ts.convertToBase64("📣❓")
'7aC97bOj4p2T'
> Buffer.from("📣❓").toString("base64")
'8J+To+Kdkw=='

🔎 Search Terms

  • ts.convertToBase64
  • emojis

🕗 Version & Regression Information

Probably a long time.

⏯ Playground Link

N/A

💻 Code

ts.convertToBase64("📣❓")

🙁 Actual behavior

7aC97bOj4p2T

🙂 Expected behavior

8J+To+Kdkw==

Contributor guide

Research direction
Look at the convertToBase64 function in src/compiler/utilities.ts and fix the encoding to properly handle multi byte characters like emojis by using the correct UTF 8 encoding logic.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65