Microsoft/TypeScript

[semantic] [typescript] No special highlighting for the 'this' parameter

Open

#48,573 opened on Apr 5, 2022

View on GitHub
 (1 comment) (2 reactions) (1 assignee)TypeScript (6,726 forks)batch import
Experience EnhancementHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.65.0
  • OS Version: macOS 12.2.1

What's wrong: The typescript semantic highlighter is currently highlighting the special 'this' parameter of function types/declarations the same as any other normal parameter.

Expectation: I would expect the 'this' keyword to be highlighted as a keyword.

Possible Solutions: Make the keyword token type "thisParameter" or add a modifier to it.

Contributor guide

Research direction
Investigate the TypeScript language service's semantic token provider to see how the 'this' parameter is classified. Look for where parameter tokens are assigned and add a specific token modifier for the 'this' parameter.
Tech stack
typescript
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptSemantic tokens
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60