Microsoft/TypeScript

JS/TS Better inlay hint positioning in multiline rest parameters

Open

#48,377 opened on Mar 22, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
Domain: LS: Inlay HintsEffort: CasualExperimentation NeededHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

The inlay hint positioning in multiline rest parameters is odd.

Considering this function

const setTags = (...tags) => { /* ... */ }

How the hint is positioned: image

What I expected it to be: image

Contributor guide

Research direction
Investigate the inlay hint rendering logic in the TypeScript language service, focusing on how hints are positioned for rest parameters. Look at the visual positioning code and adjust the offset for multiline rest parameter hints.
Tech stack
typescriptjavascript
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptEditor concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70