Microsoft/TypeScript

navigator.share is not always a function

Open

#42,809 opened on Feb 15, 2021

View on GitHub
 (7 comments) (18 reactions) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: lib.d.tsHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Bug Report

navigator.share is undefined is many browsers, yet TypeScript reports it as "the function is always defined"

🔎 Search Terms

navigator.share share

🕗 Version & Regression Information

Version 4.1.5 & Nightly

⏯ Playground Link

https://www.typescriptlang.org/play?#code/JYMwBAFAdghgbsA5jALgewE4DoDOALGDAUwEowBvAWACgw6wBjNKHNAGyKzbUQgHIAKniJhYKYHBH5CIkEVQBXYmGA4VAWwAOHdUSgoiAEz4kA3DQC+YImxwiqtekxbtO3XoOGjUEqQWVyisqqomgoGtpEuvpGJubUFkA

💻 Code

if (navigator.share) {
    console.log('The native share feature is implemented');
} else {
    console.log('The native share feature is not implemented');
}

🙁 Actual behavior

TypeScript reports it as "the function is always defined"

🙂 Expected behavior

If should report navigator.share as maybe being present.

Contributor guide

Research direction
Inspect the lib.dom.d.ts file to find the definition of Navigator.share and change it to be optional (e.g., 'share?: (data: ShareData) => Promise<void>').
Tech stack
typescript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75