Microsoft/TypeScript

TypeChecker#getConstantValue(node) doesn't properly resolve values

Open

#4,217 opened on Aug 7, 2015

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: APIHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Courtesy of @ivogabe from here.

I'm working with the compiler api and I noticed that TypeChecker#getConstantValue(node) only returns a value if I first call TypeChecker#getSymbolAtLocation(node). node is an ElementAccessExpression or a PropertyAccessExpression. Is that a bug or by design?

Contributor guide

Research direction
Check if the bug is due to lazy evaluation of constant values. Inspect the implementation of getConstantValue and its dependency on getSymbolAtLocation.
Tech stack
typescript
Domain
apicompilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptcompiler API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40