Microsoft/TypeScript

'declare method' quick fix for adding a private method

Open

#37,782 opened on Apr 3, 2020

View on GitHub
 (17 comments) (3 reactions) (0 assignees)TypeScript (6,726 forks)batch import
Good First IssueHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

From https://github.com/microsoft/vscode/issues/94118

TypeScript Version: 3.9.0-dev.20200330

Search terms

  • quick fix
  • declare method
  • private

Repro For ts file:

index.ts

class Bar {
    bar() {
         this._baz(123)
    }
}
  1. Trigger quick fixes on _baz

Feature request: https://github.com/microsoft/TypeScript/issues/36249 added a quick fix for adding private properties. However there is no quick fix for adding a private method

Playground Link:

Related Issues:

Contributor guide

Research direction
Study the existing quick fix for adding private properties (issue #36249) and extend it to generate a private method declaration.
Tech stack
typescript
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptTypeScript compiler API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50