Microsoft/TypeScript

Declaration emit for private identifiers in class expressions is wrong

Open

#36,548 opened on Jan 31, 2020

View on GitHub
 (3 comments) (2 reactions) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: Declaration EmitHelp WantedRescheduled

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Code

const O = class { #g }

Expected behavior:

declare const O = class { #private }

Actual behavior:

declare const O: {
    new (): {
        "__#1@#g": any;
    };
};

Contributor guide

Research direction
Examine the TypeScript compiler's emit logic for class expressions with private identifiers, specifically the binder and checker handling of private names.
Tech stack
typescript
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70