Microsoft/TypeScript

Type declaration of CanvasImageSource in lib.webworker.d.ts is incomplete.

Open

#29,970 opened on Feb 19, 2019

View on GitHub
 (11 comments) (2 reactions) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: lib.d.tsHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Type declaration of CanvasImageSource in lib.webworker.d.ts is now only ImageBitMap. But that should be HTMLOrSVGImageElement | HTMLVideoElement | HTMLCanvasElement | ImageBitmap https://developer.mozilla.org/en-US/docs/Web/API/CanvasImageSource

TypeScript Version: 3.4.0-dev.201190216

Search Terms: CanvasImageSource

Code

let ctx = document.createElement("canvas").getContext("2d")
let img = new Image()
ctx.drawImage(img, 0, 0)

tsconfig.json

{
  "compilerOptions": {
    "target": "es2018",
    "module": "commonjs",
    "lib": [
      "webworker",
      "es2018",
      "dom",
    ]
  }
}

whole project in https://github.com/Muratam/yabai-sample.ts

Expected behavior: No error occurs when run webpack nor webpack --watch

Actual behavior: Following error occurs when incremental build in webpack --watch "TS2345: Argument of type 'HTMLImageElement' is not assignable to parameter of type 'ImageBitmap'. Property 'close' is missing in type 'HTMLImageElement' but required in type 'ImageBitmap'"

Playground Link:

Related Issues: #25468 In that issue, only TypeScript/src/lib/dom.generated.d.ts is referred, but lib.webworker.d.ts is also needed to be referred. Please fix type declaration of CanvasImageSource in lib.webworker.d.ts

Contributor guide