Microsoft/TypeScript

Request to change currentTarget in Event interface for lib.d.ts

Open

#299 opened on Jul 29, 2014

View on GitHub
 (39 comments) (89 reactions) (0 assignees)TypeScript (48,455 stars) (6,726 forks)batch import
Domain: lib.d.tsHelp WantedSuggestion

Description

When using the Event interface from lib.d.ts, and attaching a listener, the callback will get an object of type Event. However, the Event's currentTarget property is of type EventTarget (whereas it's should be of type Element/HTMLElement).

Contributor guide

Tech stack
typescript
Domain
frontenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript basicsDOM Event fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the current type definition of Event.currentTarget in lib.d.ts. Examine the issue comments to understand proposed solutions and any concerns about breaking changes. Check for any existing PRs or attempts to fix this. Propose a type narrowing from EventTarget to HTMLElement or a more specific type, ensuring backward compatibility.
Request to change currentTarget in Event interface for lib.d.ts · Microsoft/TypeScript#299 | Good First Issue