Microsoft/TypeScript

simply logic predicate code fix or suggestion

Open

#25,175 opened on Jun 23, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
Domain: LS: RefactoringsHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Search Terms

logic, predicate, quickfix

Suggestion

provide a code fix or refactor to simply logic predicate

Use Cases

simply some complexity logic predicate is hard and always get a break change, hope have a code fix to simply that like the jetbrain idea

Examples


if (! a && !b || !a && !c) {
    // something
}

fix to:

if (!(a && (b || c))) {
    // something
}

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript / JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. new expression-level syntax)

Contributor guide

Research direction
Study the existing set of code fixes in TypeScript's language service, particularly how they detect patterns and offer refactorings. Look for the predicate simplification logic in JetBrains IDEs to understand the expected transformation. Then explore the TypeScript checker API to implement a new code fix that suggests simplification of boolean expressions.
Tech stack
typescript
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30