Microsoft/TypeScript

esmoduleinterop: Improve error message when calling static method on class

Open

#21,656 opened on Feb 6, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
Domain: Error MessagesHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

TypeScript Version: master

Code

b.d.ts:

declare class C { static m(): void }
declare namespace C {}
export = C;

import * as C from "./b";
C.m();

Expected behavior:

src/a.ts(1,1): error TS7038: A namespace-style import will import a module namespace object, not a class.
src/a.ts(2,3): error TS2339: Property 'm' does not exist on type 'typeof C'.

Actual behavior:

src/a.ts(2,3): error TS2339: Property 'm' does not exist on type 'typeof C'.

Contributor guide

Research direction
Understand the expected behavior: when using esModuleInterop, importing a class with namespace style import should produce a specific error message. Currently, only the second error is shown. Trace the checks in the TypeScript compiler for namespace imports and esModuleInterop to add the additional error.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65