Microsoft/TypeScript

Formatter: Place JSX closing tag on new line

Open

#21,124 opened on Jan 10, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (48,455 stars) (6,726 forks)batch import
Domain: FormatterHelp WantedSuggestion

Description

TypeScript Version: 2.7.0-dev.20180108

Code

<div>
    wat</div>

Expected behavior:

<div>
    wat
</div>

Actual behavior:

No changes are made by the formatter.

Related:

While not directly related, I came across this while working on a fix for #20766. I can work on a fix for this issue as well.

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with TypeScript formatter internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Start by examining the TypeScript formatter code, likely in src/services/formatting/. The issue is about JSX closing tag placement; look for logic that handles multi line JSX elements. The related issue #20766 may provide additional context. The fix should ensure that when a JSX element's content spans multiple lines, the closing tag is placed on its own line.
Formatter: Place JSX closing tag on new line · Microsoft/TypeScript#21124 | Good First Issue