Microsoft/TypeScript

Better error for semicolon after decorator

Open

#21,050 opened on Jan 6, 2018

View on GitHub
 (1 comment) (7 reactions) (0 assignees)TypeScript (6,726 forks)batch import
Domain: Error MessagesHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

TypeScript Version: 2.7.0-dev.20171230

Code

import { component } from "babyioc";

import { Member } from "./Effects";

class Example {
    @component(Member);
    public readonly member: Member;
}

Expected behavior:

file.ts(6,23): error TSXXXX: Semicolons not allowed after decorators.

Actual behavior:

file.ts(6,23): error TS1146: Declaration expected.

Not very important IMO, but a little confusing.

Contributor guide

Research direction
Look at the TypeScript parser's handling of decorators to add a specific error message when a semicolon is encountered after a decorator, instead of the generic 'Declaration expected'.
Tech stack
typescript
Domain
None
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80