Microsoft/TypeScript

Fix setTimeout/setInterval/setImmediate functions

Open

#19,635 opened on Nov 1, 2017

View on GitHub
 (6 comments) (1 reaction) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: lib.d.tsHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

Fix too lax typings.

TypeScript Version: master

Expected behavior:

declare function setTimeout(handler: (...args: any[]) => void, timeout?: number, ...args: any[]): number;

Actual behavior:

declare function setTimeout(handler: (...args: any[]) => void, timeout: number): number;
declare function setTimeout(handler: any, timeout?: any, ...args: any[]): number;

Contributor guide

Research direction
Locate the definition of setTimeout in TypeScript's standard library (likely in lib.dom.d.ts or lib.core.d.ts). Modify it to use a single overload with an optional timeout parameter. Ensure that the handler parameter is typed as (...args: any[]) => void and the return type is number. Test the change by running the TypeScript compiler tests related to setTimeout.
Tech stack
typescript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75