Microsoft/TypeScript

Flag boolean in comparison operator operands as errors

Open

#15,506 opened on May 1, 2017

View on GitHub
 (13 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
Good First IssueHelp WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

From https://github.com/Microsoft/TypeScript/issues/15444#issuecomment-298055832

var x: boolean, y: boolean;
if (x > y) {  // suspicious!
}

Contributor guide

Research direction
Understand the TypeScript compiler's type checking and AST traversal to add a new diagnostic when comparing booleans with relational operators.
Tech stack
typescript
Domain
compilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptcompiler design
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30