Microsoft/TypeScript

How tsconfig exclude pattern should actually work

Open

#12,824 opened on Dec 10, 2016

View on GitHub
 (5 comments) (7 reactions) (0 assignees)TypeScript (6,726 forks)batch import
Help WantedSuggestion

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

TypeScript Version: 2.1.1 / nightly (2.2.0-dev.201xxxxx)

Say we have a following structure to specially to test exclude pattern:

/node_modules
  /module/some.ts
nested/
  /node_modules
    /module/some.ts
  /deep-nested/
    /node_modules
      /module/some.ts

Will check this using tsc --listFiles

How exclude patterns work:

  1. "node_modules" - will exclude only /node_modules/module/some.ts
  2. "*/node_modules" (the same effect as /node_modules/") - will exclude only /nested/node_modules/module/some.ts
  3. "**/node_modules" - will exclude nothing
  4. "**/node_modules/*" - will exclude everything (also nested, deep-nested)

Some behaviour seem strange to me

  • why in case 3 it excludes nothing (considering case 2 works)?
  • by default (if exclude not specified) case 1 will be effective, shouldn't it be 4) which excludes node_modules in nested folders as well?

Contributor guide

Research direction
Investigate the glob pattern implementation in TypeScript's compiler to understand how 'node modules', '*/node modules', '**/node modules', and '**/node modules/*' behave and verify against documentation.
Tech stack
typescript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70