Microsoft/TypeScript

Line break in module declaration causes compile time error

Open

#11,167 opened on Sep 27, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: ParserHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (Avg merge 6d 17h) (9 merged PRs in 30d)

Description

TypeScript Version: 2.0.3

A line break in the declaration of a module causes a compile time error. This could either be that the language specification isn't clear that this is illegal or a bug.

Code

// Example declaration with line break
declare module 
     my.very.long.name.foo.bar.baz.able.baker {}

Expected behavior: I don't see anything in the language specification that would make this a compile time error, so I would expect the statement to work as if declaration was all on one line, ie:

// Example declaration with line break
declare module my.very.long.name.foo.bar.baz.able.baker {}

Actual behavior:

A compile time error, in particular: (1, 9): error TS1005: ';' expected.

Contributor guide

Research direction
Examine the TypeScript parser to understand why line breaks are not allowed in module declarations and identify the specific rule causing the error.
Tech stack
typescript
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85